qol[Demo]: Prevent local account creation when no Minecraft account is found and make the associated error better#16
Conversation
TODO: actually make these translatable
ThatStella7922
left a comment
There was a problem hiding this comment.
Looks sane at first glance, will test on physical device before approval
|
Thanks!
No it is not, logic at 2 am is not a good idea.
Done! Although the names may be a bit lengthy, I'm bad at naming things |
0958840 to
81987d4
Compare
|
The artifact tested: https://github.com/alexytomi/PojavLauncher/actions/runs/15783282077 app-debug-noruntime App data was cleared between tests for a clean slateTest scenario 1: Open amethyst, click add account, local account. Test scenario 2: Open amethyst, log into a Microsoft account that does not own the game (demo user), click add account, local account. Ending feedback: |
81987d4 to
9e877df
Compare
|
Hope that fixes it 😭 |
Should also fix demo message being missing in some cases (particularly in the open directory button when both a demo and ms acc is logged on)
5292e32 to
dcdcdff
Compare
ThatStella7922
left a comment
There was a problem hiding this comment.
Artifact tested: https://github.com/alexytomi/PojavLauncher/actions/runs/15792267715
App data cleared between runs
Test scenario 1: Open amethyst, click add account, local account.
Result: Error message is properly shown, nice

Test scenario 2: Open amethyst, log into a Microsoft account that does not own the game (demo user), click add account, local account.
Result:


Ending feedback:
Seems good to me. errors show up fine and the user can't add local accounts until a premium account is added, nor can they play anything pre-1.3.1 until that happens



No description provided.